Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: locales for ja #935

Merged
merged 1 commit into from
Apr 24, 2023
Merged

feat: locales for ja #935

merged 1 commit into from
Apr 24, 2023

Conversation

aki77
Copy link
Contributor

@aki77 aki77 commented Apr 23, 2023

No description provided.

bensheldon
bensheldon approved these changes Apr 24, 2023
View reviewed changes
Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aki77 Thank you 🙏🏻 This is fantastic.

@bensheldon bensheldon added the localization Updating localization strings label Apr 24, 2023
@aki77
Copy link
Contributor Author

aki77 commented Apr 24, 2023

@bensheldon

Thank you for actively maintaining good_job gem!

@bensheldon bensheldon merged commit a32e295 into bensheldon:main Apr 24, 2023
@aki77 aki77 deleted the add-ja-locale branch April 24, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensheldon bensheldon bensheldon approved these changes

Assignees
No one assigned
Labels
localization Updating localization strings
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aki77 @bensheldon